-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support for notebook tasks #7
Comments
Hey @rafaelpierre, I was looking to add the spark python task support and there is some overlap between notebook and spark python task. The default Task (pyjaws.pyjaws.api.base.Task) creates a python wheel task. Would it be better to have a class which models the various task types(notebook_task, spark_python_task, dbt_task etc) and generic class/function to create these different tasks in the workflow? I understand in this quite early on, do you have something in mind? |
Hey @aaravind100 - first of all thanks for chiming in :) That's a great idea indeed. We could have a main Task class, and different child classes inhereting from it - e.g. PythonWheelTask, NotebookTask etc. What do you think? |
Great!! I can give it go :D |
Awesome! Looking forward to your PR :) |
Resolved with #12 |
No description provided.
The text was updated successfully, but these errors were encountered: