Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for notebook tasks #7

Closed
rafaelpierre opened this issue May 13, 2023 · 5 comments
Closed

support for notebook tasks #7

rafaelpierre opened this issue May 13, 2023 · 5 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@rafaelpierre
Copy link
Owner

No description provided.

@aaravind100
Copy link
Contributor

Hey @rafaelpierre, I was looking to add the spark python task support and there is some overlap between notebook and spark python task.

The default Task (pyjaws.pyjaws.api.base.Task) creates a python wheel task. Would it be better to have a class which models the various task types(notebook_task, spark_python_task, dbt_task etc) and generic class/function to create these different tasks in the workflow?

I understand in this quite early on, do you have something in mind?

@rafaelpierre
Copy link
Owner Author

Hey @aaravind100 - first of all thanks for chiming in :)

That's a great idea indeed. We could have a main Task class, and different child classes inhereting from it - e.g. PythonWheelTask, NotebookTask etc.

What do you think?

@rafaelpierre rafaelpierre pinned this issue May 15, 2023
@rafaelpierre rafaelpierre added the help wanted Extra attention is needed label May 15, 2023
@aaravind100
Copy link
Contributor

Great!! I can give it go :D

@rafaelpierre
Copy link
Owner Author

Awesome! Looking forward to your PR :)

@rafaelpierre
Copy link
Owner Author

Resolved with #12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants