Replies: 2 comments
-
Giving users more options for the exclude list would be a good thing. We should ensure we don't negate any potential performance benefits we get from moving the Additionally it wouldn't be a bad idea to add some
Also, the javascript equivalent userscript parser. |
Beta Was this translation helpful? Give feedback.
-
Due to the proposal of #650, implementing global exclusion based on Additionally we've nicely improved the error prompt about |
Beta Was this translation helpful? Give feedback.
-
The current
global exclude list
takes the same data format as@match
metadata in thesettings
, it uses thematch patterns
defined in the browser extension API, not sure if this is the best data format for the end user, it might cause some difficulties.Although we added a error indicator for it in #341 #339, we still can't be sure users know how to fix it.
It now uses the same function in the swift layer as script injection to check this list, which is fine, but in the future we may migrate it to the javascript layer, maybe in
background
orcontent scripts
, so that we can do it earlier handle it and save some unnecessary message requests and processing.Considering the possible implementation of #334 in the future, we may eventually need to implement the same
@match
metadata parsing function in the javascript layer, which is not too much of a problem. But theglobal exclude list
can also be decoupled from the script injection process and checked before it, so we can choose to use other formats as well.Once the #331 work is complete, we will have the ability to make changes to it. So bringing this discussion up here, as well as documenting some of my current thoughts, let's think about what data format would be more appropriate.
Considering that to the end user, the
global exclude list
might be more specific to some site i.e. host domian, rather than a path, maybe a syntax like@include
metadata is easier for the end user, it's also easier in javascript easy to accomplish. If necessary, we may be able to provide both ways for users to choose in the future.Beta Was this translation helpful? Give feedback.
All reactions