Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop implementations that haven't been updated #349

Open
martinthomson opened this issue Jan 31, 2024 · 5 comments
Open

Drop implementations that haven't been updated #349

martinthomson opened this issue Jan 31, 2024 · 5 comments

Comments

@martinthomson
Copy link
Contributor

I notice that some of the implementations aren't being updated very often. Those implementations probably don't need to be run as often. They might even be hidden from the dashboard.

I didn't realize that neqo wasn't being updated, so maybe an email to a listed contact would be nice before doing this.

@marten-seemann
Copy link
Collaborator

First of all, we should notify implementations that haven't been updated in a long time, and encourage them to build their Docker image in CI. It's really easy, and there are plenty of GitHub Actions workflows around that can be copy-pasted.

I just went through the implementations and it looks that there are only two that haven't been updated in a long time (>2 months):

@lnicco
Copy link
Contributor

lnicco commented Jan 31, 2024

I just updated the mvfst image manually to unblock, it seems to be just a silly permission issue with the automation.
I'll get it fixed soon, and later explore the Github Actions workflow you posted (thanks!)

@marten-seemann
Copy link
Collaborator

@lnicco Friendly ping, has there been any progress?

@lnicco
Copy link
Contributor

lnicco commented Jul 22, 2024

@jbeshay moved the build to the main proxygen+mvfst repo and builds are generated weekly via github actions so the build is more stable and reliable. Are you still seeing issues with the images being outdated?

@marten-seemann
Copy link
Collaborator

@lnicco Sorry, I was looking at DockerHub, but you moved your registry to GitHub: https://github.com/facebook/proxygen/pkgs/container/proxygen%2Fmvfst-interop/versions?filters%5Bversion_type%5D=tagged. Seems like it's getting updated more frequently now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants