-
-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop implementations that haven't been updated #349
Comments
First of all, we should notify implementations that haven't been updated in a long time, and encourage them to build their Docker image in CI. It's really easy, and there are plenty of GitHub Actions workflows around that can be copy-pasted. I just went through the implementations and it looks that there are only two that haven't been updated in a long time (>2 months):
|
I just updated the mvfst image manually to unblock, it seems to be just a silly permission issue with the automation. |
@lnicco Friendly ping, has there been any progress? |
@jbeshay moved the build to the main proxygen+mvfst repo and builds are generated weekly via github actions so the build is more stable and reliable. Are you still seeing issues with the images being outdated? |
@lnicco Sorry, I was looking at DockerHub, but you moved your registry to GitHub: https://github.com/facebook/proxygen/pkgs/container/proxygen%2Fmvfst-interop/versions?filters%5Bversion_type%5D=tagged. Seems like it's getting updated more frequently now. |
I notice that some of the implementations aren't being updated very often. Those implementations probably don't need to be run as often. They might even be hidden from the dashboard.
I didn't realize that neqo wasn't being updated, so maybe an email to a listed contact would be nice before doing this.
The text was updated successfully, but these errors were encountered: