Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP error responses from the API should not break Web Console rendering #296

Open
insmac opened this issue Jun 3, 2024 · 0 comments
Open

Comments

@insmac
Copy link
Contributor

insmac commented Jun 3, 2024

Web Console makes certain assumptions about the error formatting (i.e. 400) coming from the HTTP API - i.e. tries to parse its content assuming they are JSON, etc. Further down the chain we are doing stuff like toLocaleString(), etc. which all can result in breaking in application render process (basically, a blank screen).

We should ensure that:

  • We are rendering the associated error message only if a format matches the expected one and it's present at all
  • Error position is set within range
  • The logic prone to breaking happens is sufficiently isolated (i.e. in a try catch blocks) to prevent crashing the application.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant