Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to fix imports for Suggest() replacements #329

Open
quasilyte opened this issue Dec 29, 2021 · 2 comments
Open

Make it possible to fix imports for Suggest() replacements #329

quasilyte opened this issue Dec 29, 2021 · 2 comments

Comments

@quasilyte
Copy link
Owner

quasilyte commented Dec 29, 2021

If we're proposing some replacement, sometimes we need to fix the imports.

There are 2 cases:

  • Some X package usage is removed after rewrite. We need to make sure that package doesn't become "imported and not used".
  • Some X package usage is added after rewrite. We need to make sure that package is imported.

Or we can imply that goimports should be used to fix the code afterwards.

@JesseObrien
Copy link

Bump on this. I need to update imports after some Suggest changes. I'm updating log items to use log/slog and need that import updated. Is the recommended way to handle this to run goimports on the files after running ruleguard?

@quasilyte
Copy link
Owner Author

Is the recommended way to handle this to run goimports on the files after running ruleguard?

Right now, it is. :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants