Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perhaps CSS imports from PDF module don't work #163

Open
FroMage opened this issue Sep 8, 2023 · 2 comments
Open

Perhaps CSS imports from PDF module don't work #163

FroMage opened this issue Sep 8, 2023 · 2 comments

Comments

@FroMage
Copy link
Contributor

FroMage commented Sep 8, 2023

At least, in the todo app, they don't seem to work anymore

@FroMage
Copy link
Contributor Author

FroMage commented Sep 12, 2023

Actually, this is due to {#bundle/} which generates a screen CSS import:

      <link rel="stylesheet" media="screen" href="/static/bundle/main-LH23AIE5.css" />

@ia3andy are you sure this is the right thing to do? It won't get loaded when doing PDF rendering.

@ia3andy
Copy link
Contributor

ia3andy commented Sep 12, 2023

Actually, this is due to {#bundle/} which generates a screen CSS import:

      <link rel="stylesheet" media="screen" href="/static/bundle/main-LH23AIE5.css" />

@ia3andy are you sure this is the right thing to do? It won't get loaded when doing PDF rendering.

I don't know why I added this 🤔 but yes we should remove this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants