Enable resolution of AI services by bean name #1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aldettinger
commented
Nov 26, 2024
•
aldettinger
commented
- Closes: Enable resolution of AI services by EL name #1087
cescoffier
reviewed
Nov 26, 2024
| @@ -381,6 +382,12 @@ public void findDeclarativeServices(CombinedIndexBuildItem indexBuildItem, | |||
|
|
|||
| String imageModelName = chatModelName; // TODO: should we have a separate setting for this? | |||
|
|
|||
| AnnotationInstance namedAnno = declarativeAiServiceClassInfo.annotation(NAMED); | |||
| Optional<String> beanName = Optional.empty(); | |||
There was a problem hiding this comment.
Is this the @nAmed annotation? We had an issue with the nonbinding aspect of that annotation in the past.
There was a problem hiding this comment.
Yes, this is @ Named annotation. So the non binding aspect is that this annotation can't be implemented well in Quarkus ? Does it apply in this specific case ? Or maybe, it's just not recommended to use it ?
There was a problem hiding this comment.
It shouldn't be a problem in this case as it is entirely opt-in
geoand
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.