Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WS-ReliableMessaging configuration options #1141

Closed
ppalaga opened this issue Dec 15, 2023 · 2 comments · Fixed by #1150
Closed

WS-ReliableMessaging configuration options #1141

ppalaga opened this issue Dec 15, 2023 · 2 comments · Fixed by #1150

Comments

@ppalaga
Copy link
Contributor

ppalaga commented Dec 15, 2023

Initial ideas:

  • The path of the decoupled endpoint
  • acknowledgementInterval
  • baseRetransmissionInterval
@ppalaga
Copy link
Contributor Author

ppalaga commented Dec 15, 2023

Looking into RMFeature source, I see that most of the settings are done on the global RMManager retrieved via bus.getExtension(RMManager.class). Hence it would make no sense to set them per client/endpoint.

Per client/endpoind should perhaps be only the interceptors, because there can be clients/endpoints in the app which do not require WS-RM.
And of course the decoupled endpoint path would be per client.

An Example config would then look like the following:

# Global config
quarkus.cxf.rm.acknowledgement-interval = 2000
quarkus.cxf.rm.base-retransmission-interval = 4000

# Client config
quarkus.cxf.client.myClient.client-endpoint-url = ...
quarkus.cxf.client.myClient.service-interface = io.quarkiverse.cxf.it.ws.rm.server.WsrmHelloService
quarkus.cxf.client.myClient.decoupled-endpoint = /wsrm/decoupled_endpoint
quarkus.cxf.client.myClient.rm.enabled = true 
# ^ true by default anyway (given the quarkus-cxf-rt-ws-rm extension is in class path)
# adds the RM interceptors to the client

# Service config
quarkus.cxf.endpoint."/wsrm".implementor = io.quarkiverse.cxf.it.ws.rm.server.WsrmHelloServiceImpl
quarkus.cxf.endpoint."/wsrm".rm.enabled = true
# ^ adds the RM interceptors to this service

@ppalaga
Copy link
Contributor Author

ppalaga commented Dec 15, 2023

I guess it would make quite a lot of sense to be able to configure logging and other common stuff for the decoupled endpoint. I am not sure whether doing it in the same way as we do for the normal endpoints would be feasible:

# quarkus.cxf.endpoint."/wsrm/decoupled_endpoint".implementor = ... I wonder whether we can omit this 
quarkus.cxf.endpoint."/wsrm/decoupled_endpoint".logging.enabled = true
quarkus.cxf.endpoint."/wsrm/decoupled_endpoint".logging.pretty = true

This task was moved to a separate issue: #1149

@ppalaga ppalaga changed the title Configuration for the decoupled endpoint and RM feature WS-ReliableMessaging configuration options Dec 22, 2023
ppalaga added a commit to ppalaga/quarkus-cxf that referenced this issue Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant