Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the color of the stop status text and icon #21749

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

stalkerok
Copy link
Contributor

2024-11-02_220507
2024-11-02_220527

Closes #21734

@Pentaphon
Copy link

Pentaphon commented Nov 2, 2024

@stalkerok I have to disagree with the text being orange. A lot of people will complain because:

  1. Orange is kind of a bright color that may indicate something is wrong, like red but medium urgency. I think orange text should mean a torrent is "stalled" like red text should indicate a torrent with an error. I outlined this in Default Transfer list colors and icons need to be tweaked into a more sensible scheme where stopped/complete = black/white, downloading = blue, uploading = green, error = red and orange = stalled. #21448
  2. The people who stop their torrents will complain about seeing a sea of orange text like they currently complain about a sea of blue text. Stopped torrents should have black text with an orange icon. Active torrents should have the icon with up/down blue/green arrows.

Personally, I think you should follow what I outlined at #21448 as people seem to be responding well to it. We should also have a discussion with the community about having a larger default color change as you seem to be willing to make default color changes.

@sledgehammer999
Copy link
Member

sledgehammer999 commented Nov 2, 2024

I don't think we should change the color in the transfer list or the sidebar. Especially not to orange.

@Pentaphon
Copy link

I don't think we should change the color in the transfer list or the sidebar. Especially not to orange.

I am fine with the text color changing to orange when a torrent is stalled so a user can see it more easily when it stalls.

Ideally, we should have a better stop icon, but somebody needs to create one.

@stalkerok
Copy link
Contributor Author

I don't think we should change the color in the transfer list or the sidebar. Especially not to orange.

Are there any pitfalls to using orange?

@Chocobo1 Chocobo1 added the Look and feel Affect UI "Look and feel" only without changing the logic label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Look and feel Affect UI "Look and feel" only without changing the logic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

STOP icon is grey instead of orange
4 participants