eth/abi: support dynamic array encoding #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
peter-chung-xfers
commented
Jun 23, 2022
•
peter-chung-xfers
commented
- support dynamic array encoding
- fix an issue that function signature calculating might be incorrect when there are params in type of dynamic array
q9f
approved these changes
Jun 27, 2022
|
Thank you! Could you run |
Co-authored-by: Afri <58883403+q9f@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## main #122 +/- ##
=======================================
Coverage 99.74% 99.74%
=======================================
Files 67 67
Lines 3855 3899 +44
=======================================
+ Hits 3845 3889 +44
Misses 10 10
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
Thank you, can you fix the tests? |
fixed |
q9f
approved these changes
Jul 1, 2022
|
Hey @q9f just wondering if you have found any viable testsuite for this? |
|
No, but there is an open ticket here: ethereum/tests#691 |
mculp
pushed a commit
to mculp/eth.rb
that referenced
this pull request
Aug 1, 2022
* eth/abi: support dynamic array encoding * eth/abi: support dynamic array encoding * Update spec/eth/abi_spec.rb Co-authored-by: Afri <58883403+q9f@users.noreply.github.com> * fix rspec * format abi_spec Co-authored-by: Afri <58883403+q9f@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.