-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] ee_lasso_regression() missing return #41
Comments
Yes it is! Thanks, I will fix in the v2.1 release |
I will point out a nuance with LASSO and the sandwich here. As stated in the documentation,
So, I didn't have a check in pytest on In general, I would recommend ridge regression currently, as convergence is a bit unstable since the derivative doesn't exist at 0 and the sandwich is invalid since the corresponding estimating equation is non-differentiable. I do plan on adding a twice-differentiable LASSO in the future, which should be valid with the sandwich variance estimator (that I still need to verify) #36 |
Nice, good to know! Thanks! |
Describe the bug
The
ee_lasso_regression()
indelicatessen.estimating_equations.regression
is missingreturn
at the end.The text was updated successfully, but these errors were encountered: