Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] ee_lasso_regression() missing return #41

Closed
yuyangstat opened this issue Feb 29, 2024 · 3 comments
Closed

[BUG] ee_lasso_regression() missing return #41

yuyangstat opened this issue Feb 29, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@yuyangstat
Copy link

Describe the bug
The ee_lasso_regression() in delicatessen.estimating_equations.regression is missing return at the end.

@yuyangstat yuyangstat added the bug Something isn't working label Feb 29, 2024
@pzivich
Copy link
Owner

pzivich commented Feb 29, 2024

Yes it is! Thanks, I will fix in the v2.1 release

@pzivich pzivich mentioned this issue Feb 29, 2024
Merged
8 tasks
pzivich added a commit that referenced this issue Feb 29, 2024
@pzivich
Copy link
Owner

pzivich commented Feb 29, 2024

I will point out a nuance with LASSO and the sandwich here. As stated in the documentation,

As the derivative of the estimating equation for LASSO is not defined at zero, the bread (and sandwich) cannot be used to estimate the variance in all settings

So, I didn't have a check in pytest on ee_lasso_regression (hence why the bug).

In general, I would recommend ridge regression currently, as convergence is a bit unstable since the derivative doesn't exist at 0 and the sandwich is invalid since the corresponding estimating equation is non-differentiable. I do plan on adding a twice-differentiable LASSO in the future, which should be valid with the sandwich variance estimator (that I still need to verify) #36

@yuyangstat
Copy link
Author

Nice, good to know! Thanks!

@pzivich pzivich closed this as completed Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants