-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT REVIEW YET] Extend paged attention #8237
Draft
vanbasten23
wants to merge
39
commits into
master
Choose a base branch
from
xiowei/extend_paged_attention
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…we call the kernel or the non-kernel
…kernel versio and compare the result.
…_xla can call into the local pallas kernel.
…n and the original paged_attention finishes successfully.
…iginal paged attention.
vanbasten23
force-pushed
the
xiowei/extend_paged_attention
branch
3 times, most recently
from
October 10, 2024 18:41
dd6dd99
to
c8a012b
Compare
…and verify the extend_paged_attention generate the same result as the original paged_attention.
vanbasten23
force-pushed
the
xiowei/extend_paged_attention
branch
from
October 10, 2024 19:57
c8a012b
to
669d598
Compare
…tion_single_query succeeded.
…re test and experiement which may be cleaned up later.
…) due to the 2nd to last dimension is 4 instead of a multiple of 8.
vanbasten23
force-pushed
the
xiowei/extend_paged_attention
branch
from
October 24, 2024 20:56
e553547
to
35a3c55
Compare
…s - 1). Sometimes, lengths[b] is very small kv_blk_idx may never reach (num_kv_blks-1) due to the check @pl.when(kv_blk_idx * compute_blk_size_kv < kv_len)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.