Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: test_clean_warn options #230

Open
jklenzing opened this issue May 6, 2024 · 0 comments
Open

ENH: test_clean_warn options #230

jklenzing opened this issue May 6, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@jklenzing
Copy link
Member

Description

pysat 3.2.0 has the ability to test for clean warnings. There are still issues with the implementation, so not fully implemented here yet.

Potential impact

  • Is the feature related to an existing problem?
    • Yes
  • How critical is this feature to your workflow?
    • Minimal, but should be examined for best testing practices
  • How wide of an impact to you anticipate this enhancement having?
    • Makes the tests longer
  • Would this break any existing functionality?
    • No

Potential solution(s)

Add _clean_warn flags to instruments. Unit tests in pysat need a bug fix first.

Alternatives

Less testing

Additional context

Waiting on fixes for pysat/pysat#1196, as well as general streamline of tests. ICON FUV currently has an HDF issue when these tests are run.

@jklenzing jklenzing added the enhancement New feature or request label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant