Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docstrings of distributions should not read x log-likelihood #7563

Open
ricardoV94 opened this issue Nov 7, 2024 · 2 comments · Fixed by tanishy7777/pymc#1 · May be fixed by #7573 or #7576
Open

Docstrings of distributions should not read x log-likelihood #7563

ricardoV94 opened this issue Nov 7, 2024 · 2 comments · Fixed by tanishy7777/pymc#1 · May be fixed by #7573 or #7576
Labels
beginner friendly docs

Comments

@ricardoV94
Copy link
Member

Description

They define a distribution or RV, that has log-probability (not just likelihood) attached, but also random methods, cdf, icdf, mean, ...

pymc/pymc/distributions/multivariate.py

Lines 195 to 197 in 22b8982

class MvNormal(Continuous):
r"""
Multivariate normal log-likelihood.

@tanishy7777
Copy link

Hey, can I work on this issue? Could you provide more details regarding the same?
@ricardoV94

@ricardoV94
Copy link
Member Author

Just rename log-likelihood to distribution

@tanishy7777 tanishy7777 mentioned this issue Nov 13, 2024
Merged
11 tasks
tanishy7777 added a commit to tanishy7777/pymc that referenced this issue Nov 13, 2024
@tanishy7777
Merge pull request #1 from tanishy7777/tanishy7777-patch-1
33617c4 
Fix for issue pymc-devs#7563
@tanishy7777 tanishy7777 linked a pull request Nov 13, 2024 that will close this issue
Open
11 tasks
@aibit0111 aibit0111 linked a pull request Nov 17, 2024 that will close this issue
Open
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beginner friendly docs
Projects
None yet
Milestone
No milestone
2 participants
@ricardoV94 @tanishy7777