Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider disabling PyTensor GC in sampling functions #7539

Open
ricardoV94 opened this issue Oct 16, 2024 · 0 comments
Open

Consider disabling PyTensor GC in sampling functions #7539

ricardoV94 opened this issue Oct 16, 2024 · 0 comments
Labels
pytensor samplers

Comments

@ricardoV94
Copy link
Member

ricardoV94 commented Oct 16, 2024 •
edited
Loading

Description

This could avoid many reallocation between function calls in the step samplers and improve throughput.

We just have to remember to call it manually when sampler finishes or is aborted.

Before we decide to go down that route we should benchmark to see if it actually helps
ricardoV94 added a commit to ricardoV94/pymc that referenced this issue Nov 23, 2024
@ricardoV94
Disable GC on logp_dlogp function
87fd299 
Related to pymc-devs#7539
@ricardoV94 ricardoV94 mentioned this issue Nov 23, 2024
Draft
2 tasks
ricardoV94 added a commit to ricardoV94/pymc that referenced this issue Nov 24, 2024
@ricardoV94
Disable GC on logp_dlogp function
0f4972c 
Related to pymc-devs#7539
ricardoV94 added a commit to ricardoV94/pymc that referenced this issue Nov 24, 2024
@ricardoV94
Disable GC on logp_dlogp function
874ae65 
Related to pymc-devs#7539
ricardoV94 added a commit to ricardoV94/pymc that referenced this issue Nov 24, 2024
@ricardoV94
Disable GC on logp_dlogp function
cb8d51e 
Related to pymc-devs#7539
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pytensor samplers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ricardoV94