Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Percent-escaped hash within URL fragment are not handled correctly #198

Open
cl0ne opened this issue Dec 23, 2020 · 0 comments
Open

Percent-escaped hash within URL fragment are not handled correctly #198

cl0ne opened this issue Dec 23, 2020 · 0 comments

Comments

@cl0ne
Copy link
Contributor

cl0ne commented Dec 23, 2020

Linking to a specific part of a documentation page with sidebar open uses an unescaped # within the URL fragment (to specify a fragment part for URL to be loaded within reference's content frame). That works perfectly fine due to forgiving nature of web browsers, but these URLs doesn't conform to RFC 3986. According to RFC, any other # within the fragment part have to be percent-encoded (see also relevant SO answer). Current implementation cannot load RFC-compliant URLs and will give 404.

For example: https://lazka.github.io/pgi-docs/index.html#Gtk-3.0/functions.html%23Gtk.main should be load the same page as https://lazka.github.io/pgi-docs/index.html#Gtk-3.0/functions.html#Gtk.main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant