Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pybamm[bpx] migrate to pydantic v2 #3964

Closed
chuckliu1979 opened this issue Apr 4, 2024 · 2 comments
Closed

pybamm[bpx] migrate to pydantic v2 #3964

chuckliu1979 opened this issue Apr 4, 2024 · 2 comments
Assignees
Labels

Comments

@chuckliu1979
Copy link

Description

the optional dependency 'bpx' 0.4.0 still use pydantic v1, it blocks others which depends on pydantic v2 to use pybamm.
I pulls a request for bpx project, and pybamm parameter_values create_from_bpx should be updated as well.

Motivation

i'm waiting FaradayInstitution/BPX#51 review. if approved and merged, create_from_bpx should be updated, accept both bpx <= 0.4.0 and new.

Possible Implementation

check bpx version, determine if need pydantic v2

Additional context

No response

@kratman kratman self-assigned this Apr 4, 2024
@kratman
Copy link
Contributor

kratman commented Apr 4, 2024

I will take a look at updating the version of BPX we use in PyBaMM, however, if pydantic v2 is not even used in BPX yet, then it will not be something you see until a release or two

@kratman
Copy link
Contributor

kratman commented May 3, 2024

I am going to close this ticket for now. Since Pydantic v2 is not available in BPX yet and there is no new version of BPX, there is nothing that can be done. A new ticket can be opened after BPX gets updated

@kratman kratman closed this as completed May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants