Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with PAAH22_C_EUOC new OPERA file #439

Open
olgalaki opened this issue Nov 7, 2024 · 8 comments
Open

Problem with PAAH22_C_EUOC new OPERA file #439

olgalaki opened this issue Nov 7, 2024 · 8 comments
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@olgalaki
Copy link

olgalaki commented Nov 7, 2024

When I tried to import OPERA PAAH22_C_EUOC hdf file in proba_rain.py error appear:

Traceback (most recent call last):
File "/home/radar/pysteps/proba_rain.py", line 125, in
main()
File "/home/radar/pysteps/proba_rain.py", line 78, in main
R, quality, metadata = io.read_timeseries(fns, importer, **importer_kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/radar/.conda/envs/pysteps/lib/python3.11/site-packages/pysteps/io/readers.py", line 53, in read_timeseries
precip_ref, quality_ref, metadata = importer(ifn, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^
File "/home/radar/.conda/envs/pysteps/lib/python3.11/site-packages/pysteps/decorators.py", line 70, in _import_with_postprocessing
precip, *other_args = importer(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/radar/.conda/envs/pysteps/lib/python3.11/site-packages/pysteps/io/importers.py", line 1364, in import_odim_hdf5
) = _read_opera_hdf5_what_group(dgg[1]["what"])
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/radar/.conda/envs/pysteps/lib/python3.11/site-packages/pysteps/io/importers.py", line 1483, in _read_opera_hdf5_what_group
qty = whatgrp.attrs["quantity"]
~~~~~~~~~~~~~^^^^^^^^^^^^
File "h5py/_objects.pyx", line 54, in h5py._objects.with_phil.wrapper
File "h5py/_objects.pyx", line 55, in h5py._objects.with_phil.wrapper
File "/home/radar/.conda/envs/pysteps/lib/python3.11/site-packages/h5py/_hl/attrs.py", line 56, in getitem
attr = h5a.open(self._id, self._e(name))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "h5py/_objects.pyx", line 54, in h5py._objects.with_phil.wrapper
File "h5py/_objects.pyx", line 55, in h5py._objects.with_phil.wrapper
File "h5py/h5a.pyx", line 80, in h5py.h5a.open
KeyError: "Can't open attribute (can't locate attribute: 'quantity')"

Could you help me with this problem?

@dnerini
Copy link
Member

dnerini commented Nov 9, 2024

hi @olgalaki, it's very plausible that a new OPERA version broke our importer. Do you know where this new version is documented? Can you share an example file?

@olgalaki
Copy link
Author

I found documentation on Opera's web page:
https://www.eumetnet.eu/wp-content/uploads/2024/06/NIMBUS_composite_vs_ODYSSEY_1.0_19062024.pdf
The difference between old and new file is described here.

I attached one example file:
T_PAAH22_C_EUOC_20241112060000.zip

@dnerini
Copy link
Member

dnerini commented Nov 12, 2024

Hi @olgalaki very good thanks, let me ask, would you be willing to contribute on this issue?

@olgalaki
Copy link
Author

Hi @dnerini,
I would like to contribute on this issue but I'm beginner in programing. Despite I will be available for further cooperation.

@dnerini dnerini added help wanted Extra attention is needed good first issue Good for newcomers labels Nov 13, 2024
@dnerini
Copy link
Member

dnerini commented Nov 13, 2024

Hi @olgalaki thanks for being open about contributing. I unfortunately have little time to dedicate to this currently, so this might need to wait, unless we find somebody else willing to have a look...

@pulkkins
Copy link
Member

Hi, @olgalaki I'll take a look at this during the coming week.

@olgalaki
Copy link
Author

@pulkkins Great, thanks.

@pulkkins
Copy link
Member

I created a branch for the new version of OPERA importer: https://github.com/pySTEPS/pysteps/tree/opera_fixes. It should now work for the new CIRRUS and NIMBUS products. I'll make a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants