Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setItem can throw an exception but there is no error handling in this library #19

Open
bagrounds opened this issue Aug 27, 2024 · 0 comments
Open

setItem can throw an exception but there is no error handling in this library #19

bagrounds opened this issue Aug 27, 2024 · 0 comments

Comments

@bagrounds
Copy link

https://developer.mozilla.org/en-US/docs/Web/API/Storage/setItem#exceptions

Shouldn't we do a try/catch in the FFI and return an Either with an error message if an exception was thrown?

purescript-web-storage/src/Web/Storage/Storage.js

Line 27 in 6b74461

storage.setItem(key, value);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bagrounds