Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing an alternative PDK image does not work #4

Open
fraenki opened this issue Mar 7, 2023 · 2 comments
Open

Passing an alternative PDK image does not work #4

fraenki opened this issue Mar 7, 2023 · 2 comments

Comments

@fraenki
Copy link

fraenki commented Mar 7, 2023

So I've tried to use the pdk "nightly" image...

       - name: Run pdk validate
         uses: puppets-epic-show-theatre/action-pdk-validate@v1.1.0
         with:
           pdk-image: puppet/pdk:nightly
           puppet-version: ${{ matrix.puppet_version }}

...but unfortunately, the GitHub Action still uses the "latest" image. From the GitHub Actions logs:

...
Download action repository 'puppets-epic-show-theatre/action-pdk-validate@v1.1.0' (SHA:4536bf103a3c2b92ddee02dfceab99a27ef2e83f)
...
Build container for action use: '/home/runner/work/_actions/puppets-epic-show-theatre/action-pdk-validate/v1.1.0/Dockerfile'.
  /usr/bin/docker build -t a5c76b:ebfbbc0bea1d492c8f1f5190da4765ee -f "/home/runner/work/_actions/puppets-epic-show-theatre/action-pdk-validate/v1.1.0/Dockerfile" "/home/runner/work/_actions/puppets-epic-show-theatre/action-pdk-validate/v1.1.0"
Sending build context to Docker daemon  41.98kB
  
Step 1/5 : ARG PDKIMAGE=puppet/pdk:latest
Step 2/5 : FROM $PDKIMAGE
latest: Pulling from puppet/pdk
...

So it looks like that pdk-image parameter does nothing. Or am I doing something wrong?

@fraenki
Copy link
Author

fraenki commented Mar 7, 2023

@cdenneen You've contributed the pdk-image functionality, maybe you could comment on this issue? Thanks :)

@vaxvms
Copy link

vaxvms commented Sep 20, 2023

I think it has never and ever worked PDFIMAGE is an ARG and not an ENV so you have to use --build-arg to use in at container build time.

According to https://github.com/orgs/community/discussions/25241 this is not supported as-is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants