Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is_virtual core fact incorrect on Windows guest on Proxmox #9519

Open
trenta opened this issue Nov 12, 2024 · 1 comment
Open

is_virtual core fact incorrect on Windows guest on Proxmox #9519

trenta opened this issue Nov 12, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@trenta
Copy link

trenta commented Nov 12, 2024

Describe the Bug

Windows guests on Proxmox return false for core fact is_virtual

Expected Behavior

They should return true

Environment

  • Puppet Version 8.10.0
  • Platform Windows Server 2022

Additional Context

Windows on vmware

Debug: Facter: List of resolvable facts: [#<Facter::SearchedFact:0x000000000a8f3770 @name="is_virtual", @fact_class=Facts::Windows::IsVirtual, @user_query="is_virtual", @type=:core, @file=nil>]
Debug: Facter: fact "is_virtual" has resolved to: true
{
  "is_virtual": true
}

Windows on proxmox

Debug: Facter: List of resolvable facts: [#<Facter::SearchedFact:0x0000000009bd8400 @name="is_virtual", @fact_class=Facts::Windows::IsVirtual, @user_query="is_virtual", @type=:core, @file=nil>]
Debug: Facter: fact "is_virtual" has resolved to: false
{
  "is_virtual": false
}

Linux on proxmox

Debug: Facter: Executing command: virt-what
Debug: Facter: fact "is_virtual" has resolved to: true
{
  "is_virtual": true
}

@trenta trenta added the bug Something isn't working label Nov 12, 2024
@austb
Copy link
Contributor

austb commented Nov 13, 2024

Linking this to its slack thread https://puppetcommunity.slack.com/archives/C0W298S9G/p1731453036716109

the system info looked like this (when the QEMU guest agent was installed)

 Get-WmiObject -Class Win32_ComputerSystem | Select-Object Manufacturer, Model, OEMStringArray

Manufacturer Model                          OEMStringArray
------------ -----                          --------------
QEMU         Standard PC (Q35 + ICH9, 2009)

It would be worth looking into if we can detect this virtualization without that installed as well https://pve.proxmox.com/wiki/Qemu-guest-agent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants