Skip to content
This repository has been archived by the owner on Sep 11, 2019. It is now read-only.

Better error handling in pipelines? #7

Open
JoeGermuska opened this issue Mar 31, 2015 · 3 comments
Open

Better error handling in pipelines? #7

JoeGermuska opened this issue Mar 31, 2015 · 3 comments

Comments

@JoeGermuska
Copy link

No doubt I should find better ways to notice what I did wrong in my code, but I found while writing a scraper that uncaught exceptions in tasks just ruins everything.

Can you catch my exceptions for me and tell me what a bozo I am?

Minor, sort of related, could you implement a ctrl-c handler?

@pudo
Copy link
Collaborator

pudo commented Mar 31, 2015

Hm, they should really all be caught in the task handler, here:

https://github.com/pudo/scrapekit/blob/master/scrapekit/tasks.py#L132

Can you share a sample of where an exception escapes this impenetrable net?

As for the Ctrl-C thing, I tried to do that before, but it ended up in a way that meant the whole program didn't terminate except with Ctrl-C :( Will dig into it again!

@JoeGermuska
Copy link
Author

maybe I just don't understand the pipeline syntax. I've had this working sometimes and then other times it just hangs. When I step through individual tasks in a REPL everything works.

https://github.com/JoeGermuska/pitchfork-scrape

@webmaven
Copy link

webmaven commented Jul 3, 2016

Is this still an active issue?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants