Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve the false-positive problem #45

Open
dogweather opened this issue Dec 31, 2018 · 0 comments
Open

Solve the false-positive problem #45

dogweather opened this issue Dec 31, 2018 · 0 comments
Assignees

Comments

@dogweather
Copy link
Member

What's scary isn't that the parser will crash when the NRS changes ... it's that it will simply produce incorrect output. That's exactly what is happening with bug #44. Many Title names are gobbledygook. But the program completed without an error message. And when I update the code to correctly parse the current format (by updating my fixtures from the live HTML), it will work, for a while. And then, the same thing may happen again.

What's interesting, though, is that the current out-of-sync code does fail tests when the fixtures are updating from the live website. Which gives me an idea: make the app self-testing. After downloading the latest HTML to export as JSON, it should first run its test suite on the new input files. Only if the tests pass should it continue to run the full application.

@dogweather dogweather self-assigned this Dec 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant