Refactor docker entrypoint.sh to better handle missing generated values #5131
+41
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the key generation in the entrypoint.sh inside the docker container. - APP_KEY is now generated with the regular artisan command - HASHIDS_SALT and HASHIDS_LENGTGH is now generated and inserted into the .env if missing. Each variable is tested individually so any existing .env files will get any variables they are missing without breaking/overwriting existing values.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the key generation in the entrypoint.sh inside the docker container.
Each variable is tested individually so any existing .env files will get any variables they are missing without breaking/overwriting existing values.