-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"paranoid" switch #39
Comments
Im a 12 hour flight tonight so thought this would be something cool to hack on if it still needs doing? |
Yeah, that'd be great! Some of those checks may already exist but the ranges for them may not match up with the "paranoid" settings. |
Having had a look at the source code there is a couple ways this could be implemented. Approach 1 Approach 2 "test": {
"key": "memory_limit",
"operation": "smaller",
"value": "128M"
} to "test": [{
"key": "memory_limit",
"operation": "smaller",
"value": "128M"
},
{
"key": "memory_limit",
"operation": "smaller",
"value": "32M",
"context": ["paranoid"]
}
] Which approach do you think is best or if you think there is a better way let me know and I could go about implementing it. test operations can then override other operations based on context. The second item in that json would also need an operation of smallerthanorequalto. For this feature to be complete the fix command needs to be updated to have contexts and apply approach 1 or approach 2. |
Something fun to have would be a "paranoid" cli option that enforces even more strict checks. This could possibly be implemented with the context handling....
Examples:
https://www.owasp.org/index.php/PHP_Configuration_Cheat_Sheet#some_more_security_paranoid_checks
The text was updated successfully, but these errors were encountered: