-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: modal which shows in which form the question is used #2467
Conversation
6291d09
to
f9e0ae3
Compare
f9e0ae3
to
ebf757f
Compare
@anehx y u no review? |
packages/form-builder/addon/components/cfb-form-editor/question-usage.hbs
Outdated
Show resolved
Hide resolved
packages/form-builder/addon/components/cfb-form-editor/question-usage.hbs
Outdated
Show resolved
Hide resolved
packages/form-builder/addon/components/cfb-form-editor/question-usage.hbs
Outdated
Show resolved
Hide resolved
Minor UX idea: Instead of the button, we could display a link only if the question is used in more than one form:
Or, if you prefer the button:
where n >= 2 |
I like the idea. That's how it looks now and I think the link is less obtrusive than the button. |
Im not sure if the inactive (no refs) state is worth it. The label would have to be „this question is not used in any other form“, since it is always used in at least one form (the one that’s currently open). And that label sounds a bit complicated and doesn’t add much value, does it? |
e6a8b24
to
73e3f23
Compare
I'm also unsure, but I wanted to cover all the possible cases. 🤷 |
To condense it to the main idea of the feature: We want to show a hint in case this question is used in any other form. And if so we want to show all the references in a modal. Right? So the link should sound: "The question is used in n other form(s)." -> excluding the current form, since that's a given. |
707e48d
to
b57c3e9
Compare
b57c3e9
to
63ab69c
Compare
Don't ask why I've added another test... just saw the existing one to late. 🤷♂️ Anyways ... it's ready for re-review @czosel |
packages/form-builder/addon/components/cfb-form-editor/question-usage.hbs
Outdated
Show resolved
Hide resolved
🎉 This PR is included in version 12.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description
This MR introduces a new modal which shows in which form a question is being used (and if that form is archived or not published).
Button which opens the modal
(I'm not sure about the label)
Modal