Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form builder: Rename "isHidden" field to "isVisible" #95

Open
JohnL17 opened this issue Mar 28, 2019 · 4 comments
Open

Form builder: Rename "isHidden" field to "isVisible" #95

JohnL17 opened this issue Mar 28, 2019 · 4 comments

Comments

@JohnL17
Copy link
Contributor

JohnL17 commented Mar 28, 2019

I think it would be better if we rename the "isHidden" field to "isVisible". When a user wants to build a form, the form should show specific fields if a radio button or a checkbox is clicked and not hide them.

For example:
'nutzungsart-wohnen' in 'nutzungsart'|answer
is more understandable than
!('nutzungsart-wohnen' in 'nutzungsart'|answer)

@anehx
Copy link
Contributor

anehx commented May 16, 2019

Actually, this behaviour is absolutely by design. If we'd name it isVisible we'd have to put in a value true per default. The default state of a field should always be "visible"..

@anehx
Copy link
Contributor

anehx commented May 16, 2019

CC @czosel @kaldras

@czosel
Copy link
Contributor

czosel commented May 16, 2019

What speaks against changing the default to true?

@anehx
Copy link
Contributor

anehx commented May 16, 2019

The default state would then be hidden, right? So if we change any related value it'd have to parse the expression again which would turn the value into some indeterminate state (running promise). So if we have an indeterminate state on a property isVisible we'd have to assume that it is false, right. This would cause a flickering form because every value change triggers recalculations of related isVisible fields

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants