Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: v3 #307

Draft
wants to merge 17 commits into
base: master
Choose a base branch
from
Draft

feat: v3 #307

wants to merge 17 commits into from

Conversation

wolfy1339
Copy link
Contributor

@wolfy1339 wolfy1339 commented Aug 23, 2024 •
edited
Loading

BREAKING CHANGE: This package has now migrated to ESM only
BREAKING CHANGE: The properties of the Client class are now private

Uzlopak and others added 4 commits August 22, 2024 16:23
@Uzlopak @wolfy1339
chore!: esm only (#306)
755242f 
BREAKING CHANGE: This package has now migrated to ESM only

Co-authored-by: wolfy1339 <webmaster@wolfy1339.com>
@wolfy1339
build(tsconfig): de-duplicate options
eae4aba
@wolfy1339
style: prettier
a47e91e
@wolfy1339 @Uzlopak
feat: add proxy support by leveraging EnvHttpProxyAgent from undici (#…
b0247a1 
…299)

Fixes #194

---------

Co-authored-by: Aras Abbasi <aras.abbasi@googlemail.com>
Uzlopak
Uzlopak reviewed Aug 23, 2024
View reviewed changes
index.ts Outdated Show resolved Hide resolved
Uzlopak
Uzlopak reviewed Aug 23, 2024
View reviewed changes
Copy link
Collaborator

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could make the properties of SmeeClient like source, target etc. private by prefixing with '#`. Maybe rename events with to eventsource?

Like this.
image

Uzlopak
Uzlopak reviewed Aug 23, 2024
View reviewed changes
index.ts Outdated Show resolved Hide resolved
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment was marked as off-topic.

Sign in to view
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 3.0.0-beta.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Uzlopak Uzlopak Uzlopak left review comments

@JasonEtco JasonEtco Awaiting requested review from JasonEtco JasonEtco will be requested when the pull request is marked ready for review JasonEtco is a code owner

@tcbyrd tcbyrd Awaiting requested review from tcbyrd tcbyrd will be requested when the pull request is marked ready for review tcbyrd is a code owner

Assignees
No one assigned
Labels
released on @beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wolfy1339 @Uzlopak