Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it possible to reoder tabs in the diagram editor #455

Open
prmr opened this issue Jan 20, 2022 · 0 comments
Open

Make it possible to reoder tabs in the diagram editor #455

prmr opened this issue Jan 20, 2022 · 0 comments
Assignees
@prmr
Labels
feature A feature request main Issues with the main code base
Milestone
Wish List

Comments

@prmr
Copy link
Owner

prmr commented Jan 20, 2022 •
edited
Loading

This is a one line change in EditorFrame:

public EditorFrame(Stage pMainStage, Optional<File> pOpenWith) 
{
    ...
    TabPane tabPane = new TabPane();
    tabPane.setTabDragPolicy(TabPane.TabDragPolicy.REORDER);

Update: Unfortunately this JavaFX feature is buggy. Tabs get stuck (impossible to open), it's impossible to close the last tab, etc. We'll revert this one for now in the hopes the feature becomes more stable.
@prmr prmr added feature A feature request main Issues with the main code base labels Jan 20, 2022
@prmr prmr added this to the Release 3.4 milestone Jan 20, 2022
@prmr prmr self-assigned this Jan 20, 2022
prmr added a commit that referenced this issue Jan 20, 2022
@prmr
#455 Change the tab drag policy to allow reordering.
fe7c2ed
@prmr prmr closed this as completed Jan 20, 2022
@prmr prmr reopened this May 2, 2022
prmr added a commit that referenced this issue May 4, 2022
@prmr
Issue #455 revert tab ordering feature
fff5f8d 
This relied on JavaFX functionality that appears not to work perfectly
at the moment.
@prmr prmr modified the milestones: Release 3.4, Wish List May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prmr prmr

Labels
feature A feature request main Issues with the main code base
Projects
None yet
Milestone
Wish List
Development

No branches or pull requests
1 participant
@prmr