Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alt_cuda_corr backward #148

Open
wonozlo opened this issue Aug 31, 2022 · 3 comments
Open

alt_cuda_corr backward #148

wonozlo opened this issue Aug 31, 2022 · 3 comments

Comments

@wonozlo
Copy link

wonozlo commented Aug 31, 2022

Hi,

Thanks for such a good research and well organized code!
I have one question about alt_cuda_corr implementation.
In the code, alt_cuda_corr is used as alt_cuda_corr.forward(fmap1,fmap2,coords,radius)
However, backward call is not used in the code.
I saw that multi gpu run also reports unused parameter, which implies that gradient is not fully propagated to the model.
Please tell me if there is something I missed!

Thanks

@XiaoyuShi97
Copy link

same question 👍

@eugenelyj
Copy link

@wonozlo I think the alt_cuda_corr is only an efficient implementation that are used for testing memory occupation when processing high-resolution input and the authors did not use this implementation for training so the backward function of alt_cuda is never called. By the way, i remember the backward implementation is wrong.

@mazeyu
Copy link

mazeyu commented Sep 6, 2024

I don't how the bug happened but I fixed this in this PR: #186

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants