Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the visual rendering of the positions #453

Open
clemlak opened this issue Nov 15, 2023 · 0 comments
Open

Update the visual rendering of the positions #453

clemlak opened this issue Nov 15, 2023 · 0 comments
Assignees

Comments

@clemlak
Copy link
Contributor

clemlak commented Nov 15, 2023

Positions in Portfolio are ERC1155 tokens and the PositionRenderer contract is responsible for generating their visual representation (including the related metadata). However, this contract was tailored for the NormalStrategy and cannot support other strategies very well.
Now we have a few different options:

  • Get rid of the PositionRenderer and don't render visual representations at all (maybe just metadata)
  • Improve the PositionRenderer so it can support different strategies
  • Let each strategy generate a visual representation by themselves
@clemlak clemlak self-assigned this Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant