Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

72 feature/banner component #97

Merged
4 commits merged into from
Oct 1, 2024
Merged

72 feature/banner component #97

4 commits merged into from
Oct 1, 2024

Conversation

ghost
Copy link

@ghost ghost commented Sep 30, 2024

๐Ÿ“ Summary

๊ณต์—ฐ ์ •๋ณด๋ฅผ ๋ฐฐ๋„ˆ ํ˜•ํƒœ๋กœ ๋‚˜ํƒ€๋‚ด๋Š” ์ปดํฌ๋„ŒํŠธ์ž…๋‹ˆ๋‹ค.

โœจ Changes

  • Banner ์ปดํฌ๋„ŒํŠธ๋ฅผ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.

๐Ÿ–ผ๏ธ Screenshots

image image

โœ… PR Checklist

  • ํ•˜๋‚˜์˜ ๋ชฉ์ ์„ ๊ฐ€์ง„ PR์ž…๋‹ˆ๋‹ค.
  • ์ฝ”๋”ฉ ์ปจ๋ฒค์…˜๊ณผ ์Šคํƒ€์ผ ๊ฐ€์ด๋“œ๋ฅผ ์ค€์ˆ˜ํ•ฉ๋‹ˆ๋‹ค. ๐Ÿ“ŒConventions
  • ๋ถˆํ•„์š”ํ•œ ์ฝ”๋“œ ์ค‘๋ณต์ด ์—†์Šต๋‹ˆ๋‹ค.
  • ์ปดํฌ๋„ŒํŠธ์˜ ์ฑ…์ž„์ด ๋‹จ์ผํ•ฉ๋‹ˆ๋‹ค.
  • ๋ฆฌ์•กํŠธ ํ›…์„ ์˜ฌ๋ฐ”๋ฅด๊ฒŒ ์‚ฌ์šฉํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ๋ฏผ๊ฐํ•œ ์ •๋ณด๋ฅผ ํฌํ•จํ•˜์ง€ ์•Š์•˜์Šต๋‹ˆ๋‹ค.
  • ๋ถˆํ•„์š”ํ•œ ์ฝ˜์†” ๋กœ๊ทธ๋‚˜ ์ฃผ์„์„ ํฌํ•จํ•˜์ง€ ์•Š์•˜์Šต๋‹ˆ๋‹ค.
  • ์ปดํฌ๋„ŒํŠธ key๊ฐ’์— ๊ณ ์œ ํ•œ ๊ฐ’์„ ํ• ๋‹นํ–ˆ์Šต๋‹ˆ๋‹ค.

๐Ÿ”— References

๐Ÿ’ฌ Comments

  • Banner ์ปดํฌ๋„ŒํŠธ๋Š” props๋กœ ํ‘œํ˜„ํ•ด ์ค„ ์ •๋ณด์™€ ๋„ˆ๋น„, ๋†’์ด๋ฅผ ๋ฐ›์Šต๋‹ˆ๋‹ค.

@ghost ghost linked an issue Sep 30, 2024 that may be closed by this pull request
@github-actions github-actions bot assigned ghost Sep 30, 2024
- ํ…์ŠคํŠธ๋ฅผ props๋กœ ์ฃผ๋˜๊ฒƒ์„ ์ด๋ฏธ์ง€๋กœ ๋Œ€์ฒดํ•จ
@ghost ghost merged commit 58e4ca2 into main Oct 1, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

๐ŸŽฏ[Feature] Banner ์ปดํฌ๋„ŒํŠธ ๊ตฌํ˜„
3 participants