Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Panel 컴포넌트 구현 #105

Merged
3 commits merged into from
Oct 4, 2024
Merged

Feat: Panel 컴포넌트 구현 #105

3 commits merged into from
Oct 4, 2024

Conversation

ghost
Copy link

@ghost ghost commented Sep 30, 2024 •
edited by ghost
Loading

📝 Summary

제목, 컨텐츠, 버튼을 그룹화한 컴포넌트입니다.

✨ Changes

  • Panel 컴포넌트를 추가했습니다.
  • PCardGrid 컴포넌트 css를 수정했습니다.(margin 수정)

🖼️ Screenshots

image image

✅ PR Checklist

  • 하나의 목적을 가진 PR입니다.
  • 코딩 컨벤션과 스타일 가이드를 준수합니다. 📌Conventions
  • 불필요한 코드 중복이 없습니다.
  • 컴포넌트의 책임이 단일합니다.
  • 리액트 훅을 올바르게 사용했습니다.
  • 민감한 정보를 포함하지 않았습니다.
  • 불필요한 콘솔 로그나 주석을 포함하지 않았습니다.
  • 컴포넌트 key값에 고유한 값을 할당했습니다.

🔗 References

💬 Comments

  • props로 panel 제목, 버튼 이름을 받습니다.
  • 버튼 이름을 주지 않으면 버튼이 생성되지 않습니다.

@ghost ghost linked an issue Sep 30, 2024 that may be closed by this pull request
🎯[Feature] Panel 컴포넌트 구현 #102
Closed
@github-actions github-actions bot assigned ghost Sep 30, 2024
shlee9999
shlee9999 requested changes Oct 1, 2024
View reviewed changes
src/components/Panel/index.tsx Outdated Show resolved Hide resolved
src/components/Panel/index.tsx Outdated Show resolved Hide resolved
src/components/Panel/index.tsx Outdated Show resolved Hide resolved
@ghost ghost force-pushed the 102-feature/panel-component branch from 5252a06 to 7c9417b Compare October 1, 2024 06:20
shlee9999
shlee9999 previously approved these changes Oct 2, 2024
View reviewed changes
@ghost ghost force-pushed the 102-feature/panel-component branch from 7e1861c to b2cde0a Compare October 2, 2024 07:43
shlee9999
shlee9999 previously approved these changes Oct 4, 2024
View reviewed changes
jymaeng1234
jymaeng1234 previously approved these changes Oct 4, 2024
View reviewed changes
@ghost ghost dismissed stale reviews from jymaeng1234 and shlee9999 via 5beb23d October 4, 2024 02:17
@ghost ghost force-pushed the 102-feature/panel-component branch from b2cde0a to 5beb23d Compare October 4, 2024 02:17
@ghost ghost force-pushed the 102-feature/panel-component branch from 5beb23d to c6d92a5 Compare October 4, 2024 02:19
@ghost ghost merged commit ec267e3 into main Oct 4, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🎯[Feature] Panel 컴포넌트 구현
3 participants
@shlee9999 @jymaeng1234 @juriurj