회원가입 컴포넌트 input 컴포넌트화 및 api 분리 #121
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
✅ Deploy Preview for how-about-it ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
live-small
reviewed
Feb 8, 2023
| @@ -5,7 +5,7 @@ type InputProps = { | |||
|
|
|||
| const WarningLabel = ({ message, style }: InputProps) => { | |||
| return ( | |||
| <label> | |||
| <label style={{ width: '330px' }}> | |||
There was a problem hiding this comment.
p1;
WarningLabel 컴포넌트 재사용을 위해선 스타일을 고정하는 것보단, 주입받는 게 좋을 거 같습니당
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Linked Issues
📖 구현 내용
🖼 구현 이미지
반영 브랜치
ex) refactor/signup/#111 -> dev
✅ PR 포인트 & 궁금한 점