Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase size allocated for institutional logo #201

Open
SteelWagstaff opened this issue Nov 25, 2019 · 3 comments
Open

Increase size allocated for institutional logo #201

SteelWagstaff opened this issue Nov 25, 2019 · 3 comments

Comments

@SteelWagstaff
Copy link
Member

SteelWagstaff commented Nov 25, 2019

Currently supported logo size for webbook/network is 40 [height] x 265 [width]:

add_theme_support(
'custom-logo', [
'height' => 40,
'width' => 265,
'flex-width' => true,
'flex-height' => true,
]
);

The logo is displayed on with a max-height of 30px. Styling rules for these logos are defined in Aetna: https://github.com/pressbooks/aetna/blob/2ba47678d0b40666e53104c9824e07d250533cc4/assets/styles/layouts/_header.scss#L20-L38

Many institutions would like this to be larger (height wise, especially) and less banner-like (ratio of less than 6.5:1, for example).

@jocelynpb2
Copy link

There has been interest in this issue here https://pressbooks.zendesk.com/agent/tickets/13038

@MichSpieler
Copy link

Another ticket where this has come up: https://pressbooks.zendesk.com/agent/tickets/20066

@SteelWagstaff
Copy link
Member Author

We did some experimentation and testing. Max-height of 50px seems like the optimal improvement. We could also add an input/option to the customizer that allows the network manager to choose their desired logo height when uploading the logo, and to use 50px as default max-height fallback value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants