Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Invalid Specifier" due to "+" character (build metadata) in semver #929

Open
3 tasks done
micschro opened this issue May 23, 2022 · 0 comments
Open
3 tasks done
Labels
bug Something isn't working

Comments

@micschro
Copy link

Describe the bug
The semver spec allows adding build metadata information to the semver string. The metadata information is added by appending it after a "+" character: `mylib-1.0.0+metainfo.
When such a semver occurs in the project package.json, the wmr build will throw with an "Invalid specifier" message.

To Reproduce
Add a module that uses a semver with metadata to the project:

"dependencies": {
	"mylib": "../mylib/mylib-1.0.1+foo.tgz"
},

And use it somehwere in the app:

import mylib from 'mylib'

Expected behavior
Semver with build metadata should be supported

Bug occurs with:

  • wmr or wmr start (development)
  • wmr build (production)
  • wmr serve (serve starts without yielding an error, but doesn't serve the app properly)

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser: chrome
  • Node Version: 16.13.1
  • WMR Version: 3.7.2

Additional context
Apparently, wmr uses a regex to match the semver parts. This regex just seems to lack the "+" character. So, just adding it like this should fix this problem:
^((?:@[\w.-]{1,200}\/)?[\w.-]{1,200})(?:@([a-z0-9^.~>=<+-]{1,50}))?(?:\/(.*))?$

@micschro micschro added the bug Something isn't working label May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant