Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unable to import Preact via UNPKG CDN #3665

Closed
trusktr opened this issue Aug 11, 2022 · 4 comments
Closed

unable to import Preact via UNPKG CDN #3665

trusktr opened this issue Aug 11, 2022 · 4 comments

Comments

@trusktr
Copy link

trusktr commented Aug 11, 2022 •
edited
Loading

Solid.js borrowed the filesystem pattern Preact uses with sub folders having package.json files (sub-packages of sorts). This format causes some ESM CDNs that don't fully support edge cases of Node ESM format to fail at making these libraries importable.

More details, discussion, and examples of both libraries and multiple CDNs in this issue:

solidjs/solid#1159
@trusktr trusktr changed the title unable to import Preact via JSPM CDN unable to import Preact via UNPKG CDN Aug 11, 2022
@trusktr trusktr mentioned this issue Aug 11, 2022
Closed
@JoviDeCroock
Copy link
Member

Not sure whether you read it but we have a pinned issue around this, thought I would mention that to be sure 😅 #2564 (comment)

@developit
Copy link
Member

Afaik the only CDNs that don't work right now are unpkg and jsdelivr.

@ekwoka
Copy link
Contributor

ekwoka commented Aug 23, 2022

just use https://esm.sh/v90/preact

@JoviDeCroock
Copy link
Member

Will close this for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@developit @trusktr @JoviDeCroock @ekwoka