Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant int() conversion #965

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Remove redundant int() conversion #965

merged 1 commit into from
Sep 21, 2023

Conversation

eumiro
Copy link
Contributor

@eumiro eumiro commented Sep 21, 2023

No description provided.

@asottile
Copy link
Member

there isn't any runtime casting in python -- this is a conversion to int

@eumiro eumiro changed the title Remove redundant int() casting Remove redundant int() conversion Sep 21, 2023
asottile
asottile approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is leftover from python 2 where math.ceil returned a float

@asottile asottile merged commit f96db96 into pre-commit:main Sep 21, 2023
5 checks passed
@eumiro eumiro deleted the drop-int branch September 22, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asottile asottile asottile approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eumiro @asottile