Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added DualScaleBar, etc. #51

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

added DualScaleBar, etc. #51

wants to merge 2 commits into from

Conversation

tait-py
Copy link

@tait-py tait-py commented Jan 2, 2023

Thank you for your package, @ppinard! I use it extensively in my own work, and over the last few weeks have been making some changes to it for my own use, which often involves plotting time-series data with scale bars in both the x and y axes. I believe some of these could be useful to other users, so I wanted to share them with you for your consideration. Please see a full changelog below. I look forward to hearing your thoughts.

  • added DualScaleBar class, which plots two aligned scale bars for both the x and y axes, and corresponding tests
  • added Time dimension to support time-series data (representing time as [si_prefix]s, not minutes/hours/etc.), and created corresponding tests
  • added the option to place a ScaleBar at a specific coordinate by passing an (x, y) coordinate to location, and updated tests and documentation accordingly
  • updated documentation to describe how to set dx when plotting non-image data
  • added new SI prefixes (as of 2022-11-22): ronna (R, 10^27), quetta (Q, 10^30), ronto (r, 10^−27) and quecto (q, 10^−30).
  • fixed typo at scalebar(340): initialize -> initialiazed
  • modified ValueError at scalebar(563) to be more descriptive: "Invalid unit ({unit}) with dimension" -> "Invalid unit ({units}) with dimension ({self._dimension.class.name})")

- added DualScaleBar class, which plots two aligned scale bars for both the x and y axes, and corresponding tests
- added Time dimension to support time-series data (representing time as [si_prefix]s, not minutes/hours/etc.), and created corresponding tests
- added the option to place a ScaleBar at a specific coordinate by passing an (x, y) coordinate to location, and updated tests and documentation accordingly
- updated documentation to describe how to set dx when plotting non-image data
- added new SI prefixes (as of 2022-11-22): ronna (R, 10^27), quetta (Q, 10^30), ronto (r, 10^−27) and quecto (q, 10^−30).
- fixed typo at scalebar(340): initialize -> initialiazed
- modified ValueError at scalebar(563) to be more descriptive: "Invalid unit ({unit}) with dimension" -> "Invalid unit ({units}) with dimension ({self._dimension.__class__.__name__})")
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant