fmt

examples/m3500_benchmark.rs

@@ -38,7 +38,7 @@ fn read_g2o(filename: &str) -> (problem::Problem, HashMap<String, na::DVector<f6
                     3,
                     vec![(id0, 3), (id1, 3)],
                     Box::new(edge),
-                    Some(Box::new(HuberLoss { scale: 1.0 })),
+                    Some(Box::new(HuberLoss::new(1.0))),
                 );
             }
             _ => {
@@ -54,7 +54,7 @@ fn read_g2o(filename: &str) -> (problem::Problem, HashMap<String, na::DVector<f6
         3,
         vec![("x0".to_string(), 3)],
         Box::new(origin_factor),
-        Some(Box::new(HuberLoss { scale: 1.0 })),
+        Some(Box::new(HuberLoss::new(1.0))),
     );
     (problem, init_values)
 }

src/loss_functions.rs

@@ -15,9 +15,15 @@ pub trait Loss: Send + Sync {
 #[pyclass]
 #[derive(Debug, Clone)]
 pub struct HuberLoss {
-    pub scale: f64,
+    scale: f64,
 }
 impl HuberLoss {
+    pub fn new(scale: f64) -> Self {
+        if scale <= 0.0 {
+            panic!("scale needs to be larger than zero");
+        }
+        HuberLoss { scale }
+    }
     fn weight(&self, abs_err: f64) -> f64 {
         if abs_err < self.scale {
             1.0

src/python/py_loss_functions.rs

@@ -6,7 +6,7 @@ use crate::loss_functions::*;
 impl HuberLoss {
     #[new]
     #[pyo3(signature=(scale=1.0))]
-    pub fn new(scale: f64) -> Self {
-        HuberLoss { scale }
+    pub fn new_py(scale: f64) -> Self {
+        HuberLoss::new(scale)
     }
 }