Drop support for node < v18 (#677)

postmanlabs · Sep 24, 2024 · abbaa06 · abbaa06
1 parent e8d30d7
commit abbaa06
Show file tree

Hide file tree

Showing 12 changed files with 7,322 additions and 4,471 deletions.
diff --git a/.eslintrc b/.eslintrc
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -19,10 +19,10 @@ jobs:
       - name: Checkout repository
         uses: actions/checkout@v3
 
-      - name: Use Node.js 16.x
+      - name: Use Node.js 18.x
         uses: actions/setup-node@v3
         with:
-          node-version: 16.x
+          node-version: 18.x
           cache: 'npm'
 
       - name: Install
@@ -39,10 +39,10 @@ jobs:
       - name: Checkout repository
         uses: actions/checkout@v3
 
-      - name: Use Node.js 16.x
+      - name: Use Node.js 18.x
         uses: actions/setup-node@v3
         with:
-          node-version: 16.x
+          node-version: 18.x
           cache: 'npm'
 
       - name: Install
@@ -57,11 +57,11 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node-version: [10, 12]
+        node-version: [18, 20]
         os: [ubuntu-latest, windows-latest]
         include:
           - coverage: true
-            node-version: 16
+            node-version: latest
             os: ubuntu-latest
 
     steps:
@@ -85,7 +85,7 @@ jobs:
 
       - if: ${{ matrix.coverage }}
         name: Upload coverage
-        run: npm run codecov -- -c -Z -f .coverage/coverage-final.json -F unit
+        run: npm run codecov -- -c -Z -f .coverage/coverage-final.json -F unit -t ${{ secrets.CODECOV_TOKEN }}
 
       - name: Run integration tests
         run: npm run test-integration
diff --git a/CHANGELOG.yaml b/CHANGELOG.yaml
@@ -1,3 +1,14 @@
+unreleased:
+  breaking changes:
+    - GH-677 Dropped support for Node < v18
+  new features:
+    - >-
+      GH-676 Updated allowed globals list to include:
+      URL, Encoding, Cryptographic, and Stream APIs
+  chores:
+    - GH-677 Updated ESLint rules
+    - GH-677 Updated dependencies
+
 2.2.0:
   date: 2024-03-13
   new features:

diff --git a/README.md b/README.md
@@ -63,25 +63,80 @@ myscope.exec('setTimeout(function () { __exitscope(null); }, 1000)', { async: tr
 
 These are the list of globals available to scripts in the scope
 
+### Standard Built-ins:
+
 ```json
 [
     "Array",          "ArrayBuffer",        "Atomics",
-    "BigInt",         "BigInt64Array",      "BigUint64Array",
-    "Boolean",        "DataView",           "Date",
-    "Error",          "EvalError",          "Float32Array",
-    "Float64Array",   "Function",           "Infinity",
-    "Int16Array",     "Int32Array",         "Int8Array",
+    "BigInt",         "Boolean",            "DataView",
+    "Date",           "Function",           "Infinity",
     "JSON",           "Map",                "Math",
     "NaN",            "Number",             "Object",
-    "Promise",        "Proxy",              "RangeError",
-    "ReferenceError", "Reflect",            "RegExp",
-    "Set",            "SharedArrayBuffer",  "String",
-    "Symbol",         "SyntaxError",        "TypeError",
-    "URIError",       "Uint16Array",        "Uint32Array",
-    "Uint8Array",     "Uint8ClampedArray",  "WeakMap",
+    "Promise",        "Proxy",              "Reflect",
+    "RegExp",         "Set",                "SharedArrayBuffer",
+    "String",         "Symbol",             "WeakMap",
     "WeakSet",        "decodeURI",          "decodeURIComponent",
     "encodeURI",      "encodeURIComponent", "escape",
     "isFinite",       "isNaN",              "parseFloat",
     "parseInt",       "undefined",          "unescape"
 ]
 ```
+### Errors:
+
+```json
+[
+    "Error",             "EvalError",    "RangeError",
+    "ReferenceError",    "SyntaxError",  "TypeError",
+    "URIError"
+]
+```
+
+### Typed Arrays:
+
+```json
+[
+    "BigInt64Array",   "BigUint64Array",     "Float32Array",
+    "Float64Array",    "Int16Array",         "Int32Array",
+    "Int8Array",       "Uint16Array",        "Uint32Array",
+    "Uint8Array",      "Uint8ClampedArray"
+]
+```
+
+### URL:
+
+```json
+[
+    "URL", "URLSearchParams"
+]
+```
+
+### Encoding:
+```json
+[
+    "atob",           "btoa",
+    "TextDecoder",    "TextDecoderStream",
+    "TextEncoder",    "TextEncoderStream"
+]
+```
+
+### Cryptography:
+```json
+[
+    "Crypto",   "CryptoKey",
+    "crypto",   "SubtleCrypto"
+]
+```
+
+### Stream:
+```json
+[
+    "ByteLengthQueuingStrategy",         "CountQueuingStrategy",
+    "CompressionStream",                 "DecompressionStream",
+    "ReadableByteStreamController",      "ReadableStream",
+    "ReadableStreamBYOBReader",          "ReadableStreamBYOBRequest",
+    "ReadableStreamDefaultController",   "ReadableStreamDefaultReader",
+    "TransformStream",                   "TransformStreamDefaultController",
+    "WritableStream",                    "WritableStreamDefaultController",
+    "WritableStreamDefaultWriter"
+]
+```
diff --git a/lib/allowed-globals.js b/lib/allowed-globals.js
@@ -1,27 +1,56 @@
-/* eslint-disable no-multi-spaces */
+/* eslint-disable one-var */
+/* eslint-disable @stylistic/js/no-multi-spaces */
+
 /**
  * Add variables here that will be available as globals inside the scope during execution.
  *
  * @const
  * @type {String[]}
  */
 module.exports = [
-    'Array',          'ArrayBuffer',        'Atomics',
-    'BigInt',         'BigInt64Array',      'BigUint64Array',
-    'Boolean',        'DataView',           'Date',
-    'Error',          'EvalError',          'Float32Array',
-    'Float64Array',   'Function',           'Infinity',
-    'Int16Array',     'Int32Array',         'Int8Array',
-    'JSON',           'Map',                'Math',
-    'NaN',            'Number',             'Object',
-    'Promise',        'Proxy',              'RangeError',
-    'ReferenceError', 'Reflect',            'RegExp',
-    'Set',            'SharedArrayBuffer',  'String',
-    'Symbol',         'SyntaxError',        'TypeError',
-    'URIError',       'Uint16Array',        'Uint32Array',
-    'Uint8Array',     'Uint8ClampedArray',  'WeakMap',
-    'WeakSet',        'decodeURI',          'decodeURIComponent',
-    'encodeURI',      'encodeURIComponent', 'escape',
-    'isFinite',       'isNaN',              'parseFloat',
-    'parseInt',       'undefined',          'unescape'
+    'Array',           'ArrayBuffer',        'Atomics',
+    'BigInt',          'Boolean',            'DataView',
+    'Date',            'Function',           'Infinity',
+    'JSON',            'Map',                'Math',
+    'NaN',             'Number',             'Object',
+    'Promise',         'Proxy',              'Reflect',
+    'RegExp',          'Set',                'SharedArrayBuffer',
+    'String',          'Symbol',             'WeakMap',
+    'WeakSet',         'decodeURI',          'decodeURIComponent',
+    'encodeURI',       'encodeURIComponent', 'escape',
+    'isFinite',        'isNaN',              'parseFloat',
+    'parseInt',        'undefined',          'unescape',
+
+    // Error
+    'Error',           'EvalError',          'RangeError',
+    'ReferenceError',  'SyntaxError',        'TypeError',
+    'URIError',
+
+    // Typed Arrays
+    'BigInt64Array',   'BigUint64Array',     'Float32Array',
+    'Float64Array',    'Int16Array',         'Int32Array',
+    'Int8Array',       'Uint16Array',        'Uint32Array',
+    'Uint8Array',      'Uint8ClampedArray',
+
+    // URL
+    'URL',             'URLSearchParams',
+
+    // Encoding
+    'atob',            'btoa',
+    'TextDecoder',     'TextDecoderStream',
+    'TextEncoder',     'TextEncoderStream',
+
+    // Cryptography
+    'Crypto',          'CryptoKey',
+    'crypto',          'SubtleCrypto',
+
+    // Stream
+    'ByteLengthQueuingStrategy',             'CountQueuingStrategy',
+    'CompressionStream',                     'DecompressionStream',
+    'ReadableByteStreamController',          'ReadableStream',
+    'ReadableStreamBYOBReader',              'ReadableStreamBYOBRequest',
+    'ReadableStreamDefaultController',       'ReadableStreamDefaultReader',
+    'TransformStream',                       'TransformStreamDefaultController',
+    'WritableStream',                        'WritableStreamDefaultController',
+    'WritableStreamDefaultWriter'
 ];
diff --git a/lib/util.js b/lib/util.js
@@ -1,6 +1,6 @@
 module.exports = {
     has (source, target) {
-        return Object.prototype.hasOwnProperty.call(source, target);
+        return Object.hasOwn(source, target);
     },
 
     isObject (subject) {