-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wip: add applet module #139
Conversation
This actually wasn't compiling with the Using this in an applet, it seems like 20a5227 has changed the styling for the applet buttons and buttons within them so the |
Otherwise this is looking good. I wonder if |
I think applets can just use |
Ah right, it's a property of |
Ahh ok, I see what you mean. I'll just make it use a custom style then? |
Perhaps the hover state visibility could be a property of the Appearance struct, or as an input parameter to our methods? I'd say do what's necessary at the moment. Our button widget refactor will have better control over styling. |
Looks like the appearance when not hovered is still like my last screenshot. With a somewhat darker circle for the button instead of matching the panel. Previously this used a completely transparent background for the button when not hovered, and an opaque background when hovered. So I guess we need that to get the same behavior. A over A = A for opaque colors, but for semi-transparent colors it gets the same color but with a higher alpha. |
Oh sorry I forgot to make the buttons text buttons again after making the fix. Backgrounds of text buttons should be completely transparent. |
Causing panic currently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a commit to not have "applet" depend on "a11y" since that was causing a panic... hopefully we can get that working well later.
Seems to be working fairly well now.
This seems to address the issues from pop-os/cosmic-applets#110 but maybe a separate trait could be added which adds the style by default.