From a9bddc5d8d8372a69a93cd9c6efc91160e25d975 Mon Sep 17 00:00:00 2001
From: Eduardo Flores <edfloreshz@gmail.com>
Date: Sat, 21 Oct 2023 18:09:00 -0700
Subject: [PATCH] feat: Add side mouse button events

---
 CHANGELOG.md             | 2 ++
 core/src/mouse/button.rs | 6 ++++++
 sctk/src/conversion.rs   | 9 ++++++++-
 winit/src/conversion.rs  | 2 ++
 4 files changed, 18 insertions(+), 1 deletion(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 7f6bdcec40..325f7d00a3 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -5,8 +5,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
+- Detect mouse side buttons.
 
 Many thanks to...
+- @edfloreshz
 - @jackpot51
 - @wash2
 
diff --git a/core/src/mouse/button.rs b/core/src/mouse/button.rs
index 3eec7f42f0..51b45c0ef9 100644
--- a/core/src/mouse/button.rs
+++ b/core/src/mouse/button.rs
@@ -10,6 +10,12 @@ pub enum Button {
     /// The middle (wheel) button.
     Middle,
 
+    /// The side button often used as "back" in web browsers.
+    Back,
+
+    /// The side button often used as "forward" in web browsers.
+    Forward,
+
     /// Some other button.
     Other(u16),
 }
diff --git a/sctk/src/conversion.rs b/sctk/src/conversion.rs
index edb8d2fe66..7d50287d82 100644
--- a/sctk/src/conversion.rs
+++ b/sctk/src/conversion.rs
@@ -9,7 +9,10 @@ use sctk::{
     reexports::client::protocol::wl_pointer::AxisSource,
     seat::{
         keyboard::Modifiers,
-        pointer::{AxisScroll, CursorIcon, BTN_LEFT, BTN_MIDDLE, BTN_RIGHT},
+        pointer::{
+            AxisScroll, CursorIcon, BTN_EXTRA, BTN_LEFT, BTN_MIDDLE, BTN_RIGHT,
+            BTN_SIDE,
+        },
     },
 };
 use xkeysym::{key, RawKeysym};
@@ -83,6 +86,10 @@ pub fn pointer_button_to_native(button: u32) -> Option<mouse::Button> {
         Some(mouse::Button::Right)
     } else if button == BTN_MIDDLE {
         Some(mouse::Button::Middle)
+    } else if button == BTN_SIDE {
+        Some(mouse::Button::Back)
+    } else if button == BTN_EXTRA {
+        Some(mouse::Button::Forward)
     } else {
         button.try_into().ok().map(mouse::Button::Other)
     }
diff --git a/winit/src/conversion.rs b/winit/src/conversion.rs
index 7c88dd3a6e..0b92d5d05f 100644
--- a/winit/src/conversion.rs
+++ b/winit/src/conversion.rs
@@ -278,6 +278,8 @@ pub fn mouse_button(mouse_button: winit::event::MouseButton) -> mouse::Button {
         winit::event::MouseButton::Left => mouse::Button::Left,
         winit::event::MouseButton::Right => mouse::Button::Right,
         winit::event::MouseButton::Middle => mouse::Button::Middle,
+        winit::event::MouseButton::Back => mouse::Button::Back,
+        winit::event::MouseButton::Forward => mouse::Button::Forward,
         winit::event::MouseButton::Other(other) => mouse::Button::Other(other),
     }
 }