Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protocol for AT-SPI #32

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Protocol for AT-SPI #32

merged 1 commit into from
Oct 30, 2024

Conversation

ids1024
Copy link
Member

@ids1024 ids1024 commented Sep 4, 2024

Draft, without documentation. This should probably have a separate object created from the manager per wl_seat (how does it work if there actually are multiple seats?) and perhaps have a name that specifies the purpose but not atspi specifically, though I don't expect anything else to legitimately use it...

@Drakulix
Copy link
Member

Drakulix commented Sep 4, 2024

This should probably have a separate object created from the manager per wl_seat (how does it work if there actually are multiple seats?)

If at-spi has no concept of multiple seats, can we somehow make sure it is the same seat libei uses?

Based on the API used by `AtspiDevice` in at-spi2-core.

The interface seems suboptimial, but the limitations are generally
related to how `AtspiDevice` works, and an improved approach will
require changes there, and in screen readers using the API.
@ids1024 ids1024 changed the title WIP Protocol for atspi Protocol for AT-SPI Oct 30, 2024
@ids1024
Copy link
Member Author

ids1024 commented Oct 30, 2024

Updated with a bit of documentation in the protocol.

As far as I can tell, this does seem to be a good mapping of the interface provided by AtspiDevice. I'm not sure anything can be meaningfully done better without also changing that, and Orca. (Which hopefully will happen, but we'll need to work with upstream on designing something for that.)

@ids1024 ids1024 marked this pull request as ready for review October 30, 2024 16:55
@jackpot51 jackpot51 merged commit ec1616b into main Oct 30, 2024
4 checks passed
@jackpot51 jackpot51 deleted the atspi-ei branch October 30, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants