Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor autohide #297

Merged
merged 8 commits into from
Nov 27, 2024
Merged

Refactor autohide #297

merged 8 commits into from
Nov 27, 2024

Conversation

wash2
Copy link
Collaborator

@wash2 wash2 commented Nov 22, 2024

It doesn't seem to be getting notified of the overlaps even when I add the global to cosmic-comp. I'll have to look more into the cosmic-comp implementation.

@wash2 wash2 marked this pull request as ready for review November 26, 2024 13:59
@wash2 wash2 requested a review from a team November 26, 2024 13:59
Copy link
Member

@Drakulix Drakulix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though we probably would want to merge this after the cosmic-comp patches to not temporarily regress the autohide behaviour.

@git-f0x
Copy link
Contributor

git-f0x commented Nov 27, 2024

Not sure if it's intended, but the panels can no longer draw outside their revealed-state container, so they just get cropped during the autohide animation (most visible with floating and rounded panels).
Also, after opening many apps and then closing them, the center segment applet positions seem to remain at the offset from the center caused by the many app icons (the segment position isn't reset).
screenshot-2024-11-27-02-06-00
Edit: The latter doesn't seem to be a regression, since I can also reproduce it on the current build (not sure if it's related to overflow).

@wash2
Copy link
Collaborator Author

wash2 commented Nov 27, 2024

Not sure if it's intended, but the panels can no longer draw outside their revealed-state container, so they just get cropped during the autohide animation (most visible with floating and rounded panels).

I'm not sure I follow. Do you have a screenshot of the issue?

@git-f0x
Copy link
Contributor

git-f0x commented Nov 27, 2024

Here's a screenshot during the dock hide animation:
screenshot-2024-11-27-15-48-54

Not sure if I'm doing something wrong (using both patched cosmic-comp and cosmic-panel), but the overlap autohide behavior sometimes stops working, and behaves the same as before.
Edit: A reliable way to reproduce it seems to be:

  1. Launch the session with a non-autohiding panel (no dock)
  2. Enable the dock, place it on the same side as the panel, and enable autohide for the dock
  3. Enable autohide for the panel

Afterwards, the panel has the old autohide behavior, even when the dock is disabled, until the session is restarted (restarting the panel by e.g. changing size isn't enough).
Also, the Dock in general has the old autohide behavior when enabled in the current session, regardless of placement, so that might be related.

@wash2 wash2 merged commit 734e3fa into master Nov 27, 2024
6 checks passed
@wash2 wash2 deleted the refactor-autohide branch November 27, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants