perf: Only enumerate trash items when necessary [Waiting on trash-rs patch] #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes: pop-os#310 Depends on Byron/trash-rs#120 which implements a function that only checks if the trash is empty or not instead of parsing each item.
|
@joshuamegnauth54 The PR has been merged on |
|
Thanks! I didn't notice that the patch has been merged. I think that COSMIC Files uses a fork of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #310
Depends on Byron/trash-rs#120 which implements a function that only checks if the trash is empty or not instead of parsing each item.