chore: update libcosmic #168
Conversation
Cargo.toml
Outdated
| sctk = { git = "https://github.com/smithay/client-toolkit//", package = "smithay-client-toolkit", rev = "e63ab5f" } | ||
| [patch.crates-io] | ||
| sctk = { package = "smithay-client-toolkit", git = "https://github.com/pop-os/client-toolkit", branch = "wayland-resize" } |
There was a problem hiding this comment.
Looks like the function added in wayland-resize isn't actually needed (though it looks like something that could be PRed and merged into upstream sctk?), and overriding both of these to e63ab5f works? (Or the most recent commit could be used, but it doesn't matter much.)
Unless that breaks vendoring or something...
There was a problem hiding this comment.
Oh, that branch is sctk 0.16, not 0.18? And sctk-adwaita is using it? So I guess this does avoid duplicating that dependency. Though it's awkward.
There was a problem hiding this comment.
Ya, it's a bit awkward. I'll try figuring out a better solution for it.
There was a problem hiding this comment.
pop-os/iced#88 & pop-os/libcosmic#238 seem to fix it
There was a problem hiding this comment.
Avoiding winit when it isn't needed is definitely an improvement.
So this line can be removed, along with a cargo update to pull in the new version?
There was a problem hiding this comment.
Yes it should be able to be removed now
wash2
force-pushed
the
update-libcosmic_jammy
branch
from
3eab6a9
to
dc7327c
Compare
No description provided.