Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion1: Subscriber inside a subscriber is not good design practice #2

Open
mbharatheesha opened this issue Jan 28, 2021 · 1 comment · May be fixed by #9
Open

Suggestion1: Subscriber inside a subscriber is not good design practice #2

mbharatheesha opened this issue Jan 28, 2021 · 1 comment · May be fixed by #9

Comments

@mbharatheesha
Copy link

Normally, it is not good design to have a subscriber inside a subscriber as implemented here and here. It's better to use the wait_for_message API to block code execution until the first sync event message is received.

@poornimajd
Copy link
Owner

It's better to use the wait_for_message

Thank you for the suggestion.I will look into this and modify the code accordingly.

This was linked to pull requests Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants