Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mmr] Use iterator for MmrLeaves #32

Open
seunlanlege opened this issue Sep 14, 2023 · 6 comments
Open

[mmr] Use iterator for MmrLeaves #32

seunlanlege opened this issue Sep 14, 2023 · 6 comments
Labels
good first issue Good for newcomers

Comments

@seunlanlege
Copy link
Member

seunlanlege commented Sep 14, 2023

When getting the leaves for a subtree, we copy into two new arrays. We can avoid this by using an iterator that sets the offset and length for subtree leaves.

@CJ13th
Copy link

CJ13th commented Nov 1, 2024

Hey @seunlanlege, is this issue still relevant? If it is, I think it could make a "good first issue" for one of the Polkadot Blockchain Academy alumni to work on during morekudos.com/carnival.

@seunlanlege
Copy link
Member Author

Hi yes it's still relevant

@CJ13th
Copy link

CJ13th commented Nov 1, 2024

Great!

I've deployed a Hyperbridge project page morekudos.com/projects/hyperbridge

Going forward, any open issues labelled as good first issue from the repos listed on your project page will automatically appear in the table.

The Kudos Carnival is a 6 week issue solving competition with the aim of getting more PBA alumni contributing to the ecosystem, so feel free to label some existing issues or generate new ones. Issues of all types are being requested, some good categories could be:

  • Building example Dapps using your team’s SDK or tech stack
  • Improving documentation
  • Bug fixing
  • Polishing existing features / UI
  • New feature requests

@seunlanlege seunlanlege added the good first issue Good for newcomers label Nov 5, 2024
@seunlanlege
Copy link
Member Author

Hi @CJ13th can you also add this repo

https://github.com/polytope-labs/sc-simnode

@CJ13th
Copy link

CJ13th commented Nov 9, 2024

@seunlanlege Added!

@Krayt78
Copy link

Krayt78 commented Nov 27, 2024

Hello @seunlanlege, i took some time to implement this change, its in this PR #43.
Let me know if any changes are needed or if i didnt understand the issue in the first place xD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants