Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to skip Data Classification, set default Classification and set default Visibility #59

Open
wapster182 opened this issue Jan 15, 2024 · 14 comments
Assignees
Labels
enhancement New feature or request

Comments

@wapster182
Copy link

Suggestion

We would love a quick option within the List "Provisioning Request Setting" with the following options:

  • Option to skip data classification (step 3)
  • Set default data classification
  • Set default visibility (e.g. always private for Teams)
@wapster182 wapster182 added the enhancement New feature or request label Jan 15, 2024
@alexc-MSFT
Copy link
Collaborator

@wapster182 I am working on some of these currently. So far I have item 1 from your list above ticked off.

The easiest way for now to implement the remainder would be to have a default data classification and visibility across the board in the settings list i.e. not for each space type e.g. team, what do you think?

@alexc-MSFT alexc-MSFT self-assigned this Jan 30, 2024
@alexc-MSFT
Copy link
Collaborator

Also with this one 'Set default data classification', do you mean setting default confidential data to Yes/No?

@wapster182
Copy link
Author

Glad to hear!

Yes, that would be fine to have one default data classification/visibility for all space types.

Correct, we would like to skip the classification step and therefore set up a default one that will be set in the request (because I guess the value needs to be filled). So it would be fine to default select Yes/No (or confedential/public).

@alexc-MSFT
Copy link
Collaborator

@wapster182 I've actually managed to implement a default visibility per space type which seems to work well.

One question, I've assumed that if they change the visibility in the app we keep the new value (even if they change the space type), thoughts?

We can add a new settings item for a default value for Confidential data.

@wapster182
Copy link
Author

I think it should work the following way:

If the "skip data classification" setting is on, it will set the visibility and confidential data value according to their respective default.
The defaults are set up for visibility per space type (in the list) and for confidential data.

If the "skip data classification" is off, it should have the visibility and confidential value prefilled with the option that is set as the default value. It obviously can be changed, and if so, can remain the user setting for this request even when changing the space type.
But all new request should always load with the default.

@alexc-MSFT
Copy link
Collaborator

Thanks @wapster182, just to explain how I've set this up to work (should match your thoughts above) before I realise it:

  1. New setting in settings list to hide the data classification screen
  2. New columns in the Provisioning Types list (see screenshot below) so you can set a default visibility and confidential data value
  3. When a user selects the type in the recommendation screen the default values will be applied (irrespective of whether the screen is hidden)
  4. If a user changes one of the values the changed value is kept until they start a new request (does not change if they change the space type)

image

image

Let me know your thoughts - thanks.

@wapster182
Copy link
Author

Perfect, seems great to me. We would love to have it realized that way.

@alexc-MSFT
Copy link
Collaborator

@wapster182 ok this is now done, you will need to add the following setting to the settings list:

image

Also, create the following columns in the Provisioning Types list please:

image

Ensure the internal name of those columns do not have any spaces

@wapster182
Copy link
Author

wapster182 commented Feb 5, 2024

After importing the new Power App solution, the Data Classification Screen throws 3 errors:

image

image

@wapster182
Copy link
Author

It seems to me that the 'Default Visibility' column is not recognized. I relinked the data sources to the enviroment variables (as described in the deployment guide) and also refreshed them, still no success.

@wapster182
Copy link
Author

Update: I digged deeper and it seems the .Value is the problem. When removing it, no error is shown anymore. So it seems the column is correctly loaded, but the data type is already text and using .Value is not possible there.

@wapster182
Copy link
Author

Update2: I removed the .Value from the commands that were throwing errors and saved & published.
Loaded the App, the steps are not displayed anymore so seems to be working.

Could you please confirm that the .Value just needs to be removed and the type text is correct? I would then proceed with further testing of the default data classification and visibility :)

@alexc-MSFT
Copy link
Collaborator

@wapster182 sorry, my bad.

Default Visibility is a CHOICE column with the values - Private, Public

A text column will give you that error.

Just chance to choice and revert your changes.

@wapster182
Copy link
Author

Makes sense, I thought it was a text column. Works great now! Can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

2 participants