-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to skip Data Classification, set default Classification and set default Visibility #59
Comments
@wapster182 I am working on some of these currently. So far I have item 1 from your list above ticked off. The easiest way for now to implement the remainder would be to have a default data classification and visibility across the board in the settings list i.e. not for each space type e.g. team, what do you think? |
Also with this one 'Set default data classification', do you mean setting default confidential data to Yes/No? |
Glad to hear! Yes, that would be fine to have one default data classification/visibility for all space types. Correct, we would like to skip the classification step and therefore set up a default one that will be set in the request (because I guess the value needs to be filled). So it would be fine to default select Yes/No (or confedential/public). |
@wapster182 I've actually managed to implement a default visibility per space type which seems to work well. One question, I've assumed that if they change the visibility in the app we keep the new value (even if they change the space type), thoughts? We can add a new settings item for a default value for Confidential data. |
I think it should work the following way: If the "skip data classification" setting is on, it will set the visibility and confidential data value according to their respective default. If the "skip data classification" is off, it should have the visibility and confidential value prefilled with the option that is set as the default value. It obviously can be changed, and if so, can remain the user setting for this request even when changing the space type. |
Thanks @wapster182, just to explain how I've set this up to work (should match your thoughts above) before I realise it:
Let me know your thoughts - thanks. |
Perfect, seems great to me. We would love to have it realized that way. |
@wapster182 ok this is now done, you will need to add the following setting to the settings list: Also, create the following columns in the Provisioning Types list please: Ensure the internal name of those columns do not have any spaces |
It seems to me that the 'Default Visibility' column is not recognized. I relinked the data sources to the enviroment variables (as described in the deployment guide) and also refreshed them, still no success. |
Update: I digged deeper and it seems the .Value is the problem. When removing it, no error is shown anymore. So it seems the column is correctly loaded, but the data type is already text and using .Value is not possible there. |
Update2: I removed the .Value from the commands that were throwing errors and saved & published. Could you please confirm that the .Value just needs to be removed and the type text is correct? I would then proceed with further testing of the default data classification and visibility :) |
@wapster182 sorry, my bad. Default Visibility is a CHOICE column with the values - Private, Public A text column will give you that error. Just chance to choice and revert your changes. |
Makes sense, I thought it was a text column. Works great now! Can be closed. |
Suggestion
We would love a quick option within the List "Provisioning Request Setting" with the following options:
The text was updated successfully, but these errors were encountered: